From 24d64102fe8b76f0031422b7b47b1f0cb672e01e Mon Sep 17 00:00:00 2001 From: Guilherme Gallo Date: Mon, 5 Aug 2024 18:40:01 -0300 Subject: [PATCH] bin/ci: crnm: Don't overwrite the global sets The skip_follow_statuses variable, used to check if we need to stay monitoring the pipeline instead of jumping to the target job traces, is based on COMPLETED_STATUSES set. But, in Python, we do shallow copies by default, and changes on skip_follow_statuses reflected on COMPLETED_STATUSES, which was making manual dependencies stop playing when --force-manual was not given. Fixes: 84d401aebf0832741716f947dd7e2e9aac1221ac Signed-off-by: Guilherme Gallo Part-of: --- bin/ci/ci_run_n_monitor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/ci/ci_run_n_monitor.py b/bin/ci/ci_run_n_monitor.py index eab53110080..ba48fda7537 100755 --- a/bin/ci/ci_run_n_monitor.py +++ b/bin/ci/ci_run_n_monitor.py @@ -126,7 +126,7 @@ def monitor_pipeline( target_id: int = -1 name_field_pad: int = len(max(dependencies, key=len))+2 # In a running pipeline, we can skip following job traces that are in these statuses. - skip_follow_statuses = COMPLETED_STATUSES + skip_follow_statuses = COMPLETED_STATUSES.copy() if not force_manual: # If the target job is marked as manual and we don't force it to run, it will be skipped. skip_follow_statuses.add("manual")