AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco/tests: do not use mul with constant to tests neg modifier

Browse Source 
The neg can be moved to the constant operand, which defeats the point
of the test.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30781>
This commit is contained in:
Georg Lehmann
2024-08-22 15:27:49 +02:00
committed by Marge Bot
parent bf67ac30fe
commit 246e22ff4f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/compiler/tests/test_optimizer.cpp
+3 -3
View File
@@ -19,11 +19,11 @@ BEGIN_TEST(optimize.neg)
writeout(0, bld.vop2(aco_opcode::v_mul_f32, bld.def(v1), inputs[0], neg_b));
//~gfx9! v1: %neg_a = v_mul_f32 -1.0, %a
//~gfx9! v1: %res1 = v_mul_f32 0x123456, %neg_a
//~gfx10! v1: %res1 = v_mul_f32 0x123456, -%a
//~gfx9! v1: %res1 = v_max_f32 0x123456, %neg_a
//~gfx10! v1: %res1 = v_max_f32 0x123456, -%a
//! p_unit_test 1, %res1
Temp neg_a = fneg(inputs[0]);
writeout(1, bld.vop2(aco_opcode::v_mul_f32, bld.def(v1), Operand::c32(0x123456u), neg_a));
writeout(1, bld.vop2(aco_opcode::v_max_f32, bld.def(v1), Operand::c32(0x123456u), neg_a));
//! v1: %res2 = v_mul_f32 %a, %b
//! p_unit_test 2, %res2