AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nir/format_convert: Assert that UNORM formats are <= 16 bits

Browse Source 
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28793>
This commit is contained in:
Faith Ekstrand
2024-06-18 10:52:51 -05:00
committed by Marge Bot
parent 5f5f4474f6
commit 22f1b04a99
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/nir/nir_format_convert.c
+5 -1
View File
@@ -199,7 +199,11 @@ _nir_format_norm_factor(nir_builder *b, const unsigned *bits,
nir_const_value factor[NIR_MAX_VEC_COMPONENTS]; nir_const_value factor[NIR_MAX_VEC_COMPONENTS];
memset(factor, 0, sizeof(factor)); memset(factor, 0, sizeof(factor));
for (unsigned i = 0; i < num_components; i++) { for (unsigned i = 0; i < num_components; i++) {
assert(bits[i] <= 32); /* A 16-bit float only has 23 bits of mantissa. This isn't enough to
* convert 24 or 32-bit UNORM/SNORM accurately. For that, we would need
* fp64 or some sort of fixed-point math.
*/
assert(bits[i] <= 16);
factor[i].f32 = (1ull << (bits[i] - is_signed)) - 1; factor[i].f32 = (1ull << (bits[i] - is_signed)) - 1;
} }
return nir_build_imm(b, num_components, 32, factor); return nir_build_imm(b, num_components, 32, factor);