From 228c091f5e2554655a8c9d61e56eefe6db9dfd67 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Fri, 22 Aug 2025 11:51:22 +0200 Subject: [PATCH] radv: add radv_cmd_set_line_stipple_enable() Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index d554b87fc42..1d0479adbb6 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -216,6 +216,16 @@ radv_cmd_set_polygon_mode(struct radv_cmd_buffer *cmd_buffer, VkPolygonMode poly state->dirty_dynamic |= RADV_DYNAMIC_POLYGON_MODE; } +ALWAYS_INLINE static void +radv_cmd_set_line_stipple_enable(struct radv_cmd_buffer *cmd_buffer, bool line_stipple_enable) +{ + struct radv_cmd_state *state = &cmd_buffer->state; + + state->dynamic.vk.rs.line.stipple.enable = line_stipple_enable; + + state->dirty_dynamic |= RADV_DYNAMIC_LINE_STIPPLE_ENABLE; +} + static void radv_bind_dynamic_state(struct radv_cmd_buffer *cmd_buffer, const struct radv_dynamic_state *src) { @@ -421,7 +431,12 @@ radv_bind_dynamic_state(struct radv_cmd_buffer *cmd_buffer, const struct radv_dy } } - RADV_CMP_COPY(vk.rs.line.stipple.enable, RADV_DYNAMIC_LINE_STIPPLE_ENABLE); + if (copy_mask & RADV_DYNAMIC_LINE_STIPPLE_ENABLE) { + if (dest->vk.rs.line.stipple.enable != src->vk.rs.line.stipple.enable) { + radv_cmd_set_line_stipple_enable(cmd_buffer, src->vk.rs.line.stipple.enable); + } + } + RADV_CMP_COPY(vk.rs.depth_clip_enable, RADV_DYNAMIC_DEPTH_CLIP_ENABLE); RADV_CMP_COPY(vk.rs.conservative_mode, RADV_DYNAMIC_CONSERVATIVE_RAST_MODE); RADV_CMP_COPY(vk.rs.provoking_vertex, RADV_DYNAMIC_PROVOKING_VERTEX_MODE); @@ -8542,11 +8557,7 @@ VKAPI_ATTR void VKAPI_CALL radv_CmdSetLineStippleEnableEXT(VkCommandBuffer commandBuffer, VkBool32 stippledLineEnable) { VK_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer); - struct radv_cmd_state *state = &cmd_buffer->state; - - state->dynamic.vk.rs.line.stipple.enable = stippledLineEnable; - - state->dirty_dynamic |= RADV_DYNAMIC_LINE_STIPPLE_ENABLE; + radv_cmd_set_line_stipple_enable(cmd_buffer, stippledLineEnable); } VKAPI_ATTR void VKAPI_CALL