From 219c53e6fca818e42ee5837c4e7f6e5253ea989f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Wed, 20 Aug 2025 11:23:17 +0200 Subject: [PATCH] aco/ra: don't clear lateKill operands in get_reg_create_vector() Fixes: 08f088479a40b2f8c76064f4f9939c53a6d03a9b ('aco/ra: set late-kill for operands of temporary p_create_vector') Part-of: --- src/amd/ci/radv-gfx1201-fails.txt | 4 ---- src/amd/compiler/aco_register_allocation.cpp | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/amd/ci/radv-gfx1201-fails.txt b/src/amd/ci/radv-gfx1201-fails.txt index 67fbcdc9b3e..f26dc9dd973 100644 --- a/src/amd/ci/radv-gfx1201-fails.txt +++ b/src/amd/ci/radv-gfx1201-fails.txt @@ -52,7 +52,3 @@ dEQP-VK.compute.shader_object_spirv.cooperative_matrix.khr_r.subgroupscope.conve dEQP-VK.compute.shader_object_spirv.cooperative_matrix.khr_r.subgroupscope.convert.input_float32_t_output_bfloat16_t.buffer.rowmajor,Fail dEQP-VK.compute.shader_object_spirv.cooperative_matrix.khr_r.subgroupscope.convert.input_float32_t_output_bfloat16_t.physical_buffer.rowmajor,Fail dEQP-VK.compute.shader_object_spirv.cooperative_matrix.khr_r.subgroupscope.convert.input_float32_t_output_bfloat16_t.workgroup.rowmajor,Fail - -# Very recent ACO regression 0c590eb90328b39e38b742125fe14ee1f56c79da -dEQP-VK.ray_query.builtin.rayqueryterminate.call.aabbs,Crash -dEQP-VK.ray_query.builtin.rayqueryterminate.call.triangles,Crash diff --git a/src/amd/compiler/aco_register_allocation.cpp b/src/amd/compiler/aco_register_allocation.cpp index 316e7fd7729..7f8c804e84f 100644 --- a/src/amd/compiler/aco_register_allocation.cpp +++ b/src/amd/compiler/aco_register_allocation.cpp @@ -2166,7 +2166,7 @@ get_reg_create_vector(ra_ctx& ctx, const RegisterFile& reg_file, Temp temp, tmp_file.fill_killed_operands(instr.get()); for (unsigned i = 0; i < instr->operands.size(); i++) { - if ((correct_pos_mask >> i) & 1u && instr->operands[i].isKill()) + if ((correct_pos_mask >> i) & 1u && instr->operands[i].isKillBeforeDef()) tmp_file.clear(instr->operands[i]); }