From 217685108a17aa96c5ccb0b1ed55ea5d51381240 Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Mon, 16 Jun 2025 01:57:26 -0700 Subject: [PATCH] gfxstream: free up hwvulkan_device_t upon driver unloading Per , the hw_device_t::close() function is called upon driver unloading. The behavior has been like this since Android 10. Acked-by: Rob Clark Part-of: --- src/gfxstream/guest/vulkan/gfxstream_vk_android.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gfxstream/guest/vulkan/gfxstream_vk_android.cpp b/src/gfxstream/guest/vulkan/gfxstream_vk_android.cpp index 2ea6591018c..8ca240e38d2 100644 --- a/src/gfxstream/guest/vulkan/gfxstream_vk_android.cpp +++ b/src/gfxstream/guest/vulkan/gfxstream_vk_android.cpp @@ -63,6 +63,11 @@ static int gfxstream_vk_hal_open(const struct hw_module_t* mod, const char* id, } static int gfxstream_vk_hal_close(struct hw_device_t* dev) { - /* hwvulkan.h claims that hw_device_t::close() is never called. */ - return -1; + /* the hw_device_t::close() function is called upon driver unloading */ + assert(dev->version == HWVULKAN_DEVICE_API_VERSION_0_1); + assert(dev->module == &HAL_MODULE_INFO_SYM.common); + + hwvulkan_device_t *hal_dev = container_of(dev, hwvulkan_device_t, common); + free(hal_dev); + return 0; }