From 1ff7ec0c9e327312b144b4c8b3a12f65c30ab148 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Thu, 18 May 2023 22:56:11 -0400 Subject: [PATCH] pan/bi: Fix atomic exchange on Valhall Copypaste fail when switching to unified atomics, missed becuase I don't have any Valhall hardware and Valhall isn't in CI. (Good news, that means it probably didn't affect anyone in the mean time :-p) Fixes crashes with lots of dEQP-GLES31 tests observed under drm-shim. Fixes: e258083e072 ("pan/bi: Use unified atomics") Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/compiler/bifrost_compile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/compiler/bifrost_compile.c b/src/panfrost/compiler/bifrost_compile.c index fc36cd2dae6..c7313ddd99a 100644 --- a/src/panfrost/compiler/bifrost_compile.c +++ b/src/panfrost/compiler/bifrost_compile.c @@ -1632,7 +1632,7 @@ bi_emit_intrinsic(bi_builder *b, nir_intrinsic_instr *instr) if (op == nir_atomic_op_xchg) { bi_emit_axchg_to(b, dst, bi_src_index(&instr->src[0]), &instr->src[1], - BI_SEG_WLS); + BI_SEG_NONE); } else { assert(nir_src_bit_size(instr->src[1]) == 32);