From 1f86a4ee3795f9c1e5d7c95255f5266b86305b86 Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Fri, 12 Sep 2025 12:19:13 +0300 Subject: [PATCH] brw: remove unused RT write code With 4fda724fd4 ("brw: Avoid invalid access when compacting out-of-bounds JIP/UIP") this stuff isn't needed anymore. Signed-off-by: Lionel Landwerlin Fixes: fe38fb858c ("brw: workaround broken indirect RT messages on Gfx11") Reviewed-by: Sagar Ghuge Reviewed-by: Ian Romanick Part-of: --- src/intel/compiler/brw_compile_fs.cpp | 5 ----- src/intel/compiler/brw_lower_logical_sends.cpp | 10 +++++----- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/intel/compiler/brw_compile_fs.cpp b/src/intel/compiler/brw_compile_fs.cpp index 2299899b5e8..cd28b88f16b 100644 --- a/src/intel/compiler/brw_compile_fs.cpp +++ b/src/intel/compiler/brw_compile_fs.cpp @@ -61,9 +61,6 @@ brw_do_emit_fb_writes(brw_shader &s, int nr_color_regions, bool replicate_alpha) struct brw_wm_prog_data *prog_data = brw_wm_prog_data(s.prog_data); const brw_builder bld = brw_builder(&s); - const bool double_rt_writes = s.devinfo->ver == 11 && - prog_data->coarse_pixel_dispatch == INTEL_SOMETIMES; - brw_fb_write_inst *write = NULL; for (int target = 0; target < nr_color_regions; target++) { /* Skip over outputs that weren't written. */ @@ -82,7 +79,6 @@ brw_do_emit_fb_writes(brw_shader &s, int nr_color_regions, bool replicate_alpha) target, 4, false); } - bool flag_dummy_message = write && double_rt_writes; if (write) { write->last_rt = true; write->eot = true; @@ -114,7 +110,6 @@ brw_do_emit_fb_writes(brw_shader &s, int nr_color_regions, bool replicate_alpha) write = brw_emit_single_fb_write(s, bld, tmp, reg_undef, reg_undef, 0, 4, use_null_rt); write->last_rt = true; - write->has_no_mask_send_params = flag_dummy_message; write->eot = true; } } diff --git a/src/intel/compiler/brw_lower_logical_sends.cpp b/src/intel/compiler/brw_lower_logical_sends.cpp index 3b164af389f..1475d2a974e 100644 --- a/src/intel/compiler/brw_lower_logical_sends.cpp +++ b/src/intel/compiler/brw_lower_logical_sends.cpp @@ -467,11 +467,13 @@ lower_fb_write_logical_send(const brw_builder &bld, brw_fb_write_inst *write, brw_fb_write_desc(devinfo, target, msg_ctl, last_rt, 0 /* coarse_rt_write */); + const bool double_rt_writes = devinfo->verx10 == 110 && + prog_data->coarse_pixel_dispatch == INTEL_SOMETIMES; + brw_reg desc_reg = brw_imm_ud(0); - if (prog_data->coarse_pixel_dispatch == INTEL_SOMETIMES && - !write->has_no_mask_send_params) { + if (prog_data->coarse_pixel_dispatch == INTEL_SOMETIMES) { assert(devinfo->ver >= 11); - if (devinfo->ver != 11) { + if (!double_rt_writes) { const brw_builder &ubld = bld.scalar_group().annotate("Coarse bit"); brw_reg coarse_bit = @@ -518,8 +520,6 @@ lower_fb_write_logical_send(const brw_builder &bld, brw_fb_write_inst *write, send->check_tdr = true; send->has_side_effects = true; - const bool double_rt_writes = devinfo->ver == 11 && - prog_data->coarse_pixel_dispatch == INTEL_SOMETIMES; if (double_rt_writes) { brw_check_dynamic_msaa_flag(bld, prog_data, INTEL_MSAA_FLAG_COARSE_RT_WRITES);