From 1f6e20cca6cdde5d4b4a108443f19d62160bc0ea Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 25 Sep 2023 12:51:08 -0700 Subject: [PATCH] freedreno/a6xx: Remove dummy packet for globals Unneeded since commit b43e5aec0d2c ("freedreno/batch: Move submit bo tracking to batch") Signed-off-by: Rob Clark Part-of: --- .../drivers/freedreno/a6xx/fd6_compute.cc | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/src/gallium/drivers/freedreno/a6xx/fd6_compute.cc b/src/gallium/drivers/freedreno/a6xx/fd6_compute.cc index fb60a744916..5b94f4567ae 100644 --- a/src/gallium/drivers/freedreno/a6xx/fd6_compute.cc +++ b/src/gallium/drivers/freedreno/a6xx/fd6_compute.cc @@ -109,7 +109,6 @@ fd6_launch_grid(struct fd_context *ctx, const struct pipe_grid_info *info) in_dt { struct fd6_compute_state *cs = (struct fd6_compute_state *)ctx->compute; struct fd_ringbuffer *ring = ctx->batch->draw; - unsigned nglobal = 0; if (unlikely(!cs->v)) { struct ir3_shader_state *hwcso = (struct ir3_shader_state *)cs->hwcso; @@ -165,23 +164,6 @@ fd6_launch_grid(struct fd_context *ctx, const struct pipe_grid_info *info) in_dt if (cs->v->need_driver_params || info->input) fd6_emit_cs_driver_params(ctx, ring, cs, info); - u_foreach_bit (i, ctx->global_bindings.enabled_mask) - nglobal++; - - if (nglobal > 0) { - /* global resources don't otherwise get an OUT_RELOC(), since - * the raw ptr address is emitted in ir3_emit_cs_consts(). - * So to make the kernel aware that these buffers are referenced - * by the batch, emit dummy reloc's as part of a no-op packet - * payload: - */ - OUT_PKT7(ring, CP_NOP, 2 * nglobal); - u_foreach_bit (i, ctx->global_bindings.enabled_mask) { - struct pipe_resource *prsc = ctx->global_bindings.buf[i]; - OUT_RELOC(ring, fd_resource(prsc)->bo, 0, 0, 0); - } - } - OUT_PKT7(ring, CP_SET_MARKER, 1); OUT_RING(ring, A6XX_CP_SET_MARKER_0_MODE(RM6_COMPUTE));