From 1e03796fa4cf4016a44ae1d31d33e179985a35d4 Mon Sep 17 00:00:00 2001 From: Tony Wasserka Date: Mon, 22 Mar 2021 17:10:05 +0100 Subject: [PATCH] aco/isel: Don't request sign extension when truncating signed integers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This doesn't change semantics but allows us to reject this potentially ambiguous configuration in convert_int in a later change. Reviewed-by: Daniel Schürmann Part-of: --- src/amd/compiler/aco_instruction_selection.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp index 5f127b61d35..e386651842c 100644 --- a/src/amd/compiler/aco_instruction_selection.cpp +++ b/src/amd/compiler/aco_instruction_selection.cpp @@ -2836,8 +2836,10 @@ void visit_alu_instr(isel_context *ctx, nir_alu_instr *instr) sgpr_extract_sext : sgpr_extract_undef; extract_8_16_bit_sgpr_element(ctx, dst, &instr->src[0], mode); } else { + const unsigned input_bitsize = instr->src[0].src.ssa->bit_size; + const unsigned output_bitsize = instr->dest.dest.ssa.bit_size; convert_int(ctx, bld, get_alu_src(ctx, instr->src[0]), - instr->src[0].src.ssa->bit_size, instr->dest.dest.ssa.bit_size, true, dst); + input_bitsize, output_bitsize, output_bitsize > input_bitsize, dst); } break; }