From 1cad339409d437ba1170725f7575b016c7c896e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Ondra=C4=8Dka?= Date: Tue, 25 Jun 2024 11:27:47 +0200 Subject: [PATCH] r300: bias presubtract fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We need to double check that the source is indeed constant before looking at the constant type. Signed-off-by: Pavel Ondračka Fixes: 0508db91556242c57029ad538613c2b1ee1969ef Part-of: --- src/gallium/drivers/r300/compiler/radeon_optimize.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r300/compiler/radeon_optimize.c b/src/gallium/drivers/r300/compiler/radeon_optimize.c index 923799aecd7..38c6355ca1a 100644 --- a/src/gallium/drivers/r300/compiler/radeon_optimize.c +++ b/src/gallium/drivers/r300/compiler/radeon_optimize.c @@ -627,7 +627,10 @@ static int peephole_mad_presub_bias( if (rc_inline_to_float(src1_reg.Index) != 2.0f) return 0; } else { - struct rc_constant *constant = &c->Program.Constants.Constants[src1_reg.Index]; + if (src1_reg.File != RC_FILE_CONSTANT) + return 0; + + struct rc_constant *constant = &c->Program.Constants.Constants[src1_reg.Index]; if (constant->Type != RC_CONSTANT_IMMEDIATE) return 0; for (i = 0; i < 4; i++) {