From 1a8a16f99de9bf0c990279b4a3e1e92593968a8b Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Fri, 19 Sep 2025 13:46:20 -0700 Subject: [PATCH] freedreno/a6xx: Move reg to static-non-context RB_UNKNOWN_8E09 is a non-context reg, we just need to set it and forget it, so move it to static-regs. Signed-off-by: Rob Clark Part-of: --- src/gallium/drivers/freedreno/a6xx/fd6_emit.cc | 2 ++ src/gallium/drivers/freedreno/a6xx/fd6_gmem.cc | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a6xx/fd6_emit.cc b/src/gallium/drivers/freedreno/a6xx/fd6_emit.cc index ff23845c9e9..1a01320b1a9 100644 --- a/src/gallium/drivers/freedreno/a6xx/fd6_emit.cc +++ b/src/gallium/drivers/freedreno/a6xx/fd6_emit.cc @@ -909,6 +909,8 @@ fd6_emit_static_non_context_regs(struct fd_context *ctx, fd_cs &cs) } ncrb.add(A6XX_PC_UNKNOWN_9E72()); + if (CHIP == A7XX) + ncrb.add(RB_UNKNOWN_8E09(CHIP, 0x4)); } /** diff --git a/src/gallium/drivers/freedreno/a6xx/fd6_gmem.cc b/src/gallium/drivers/freedreno/a6xx/fd6_gmem.cc index 73d38dcc361..389ffc3db61 100644 --- a/src/gallium/drivers/freedreno/a6xx/fd6_gmem.cc +++ b/src/gallium/drivers/freedreno/a6xx/fd6_gmem.cc @@ -1052,13 +1052,12 @@ template static void fd7_emit_static_binning_regs(fd_cs &cs) { - fd_ncrb ncrb(cs, 6); + fd_ncrb ncrb(cs, 5); ncrb.add(RB_UNKNOWN_8812(CHIP, 0x0)); ncrb.add(RB_CCU_DBG_ECO_CNTL(CHIP, 0x0)); ncrb.add(GRAS_UNKNOWN_8007(CHIP, 0x0)); ncrb.add(GRAS_MODE_CNTL(CHIP, 0x2)); - ncrb.add(RB_UNKNOWN_8E09(CHIP, 0x4)); ncrb.add(RB_CLEAR_TARGET(CHIP, .clear_mode = CLEAR_MODE_GMEM)); } @@ -2045,7 +2044,7 @@ fd6_emit_sysmem_prep(struct fd_batch *batch) assert_dt .add(GRAS_MODE_CNTL(CHIP, 0x2)); } - with_crb (cs, 12) { + with_crb (cs, 11) { set_window_offset(crb, 0, 0); set_bin_size(crb, NULL, { @@ -2057,7 +2056,6 @@ fd6_emit_sysmem_prep(struct fd_batch *batch) assert_dt crb.add(RB_UNKNOWN_8812(CHIP, 0x3ff)); // all buffers in sysmem crb.add(RB_CCU_DBG_ECO_CNTL(CHIP, batch->ctx->screen->info->a6xx.magic.RB_CCU_DBG_ECO_CNTL)); crb.add(GRAS_UNKNOWN_8007(CHIP, 0x0)); - crb.add(RB_UNKNOWN_8E09(CHIP, 0x4)); } /* enable stream-out, with sysmem there is only one pass: */