From 19bee260565a4a37aa89381a95f0e8847405e940 Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Wed, 2 Jul 2025 14:33:57 -0400 Subject: [PATCH] nak: Surface handles are not allowed to be rZ The chances of this happening are near zero with the way we do surface ops today but I have seen it in the wild and this is apparently a rule. The hardware throws an illegal instruction encoding if it sees 255. Cc: mesa-stable Part-of: --- src/nouveau/compiler/nak/ir.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nouveau/compiler/nak/ir.rs b/src/nouveau/compiler/nak/ir.rs index dc19b7ecb23..bb896c8540b 100644 --- a/src/nouveau/compiler/nak/ir.rs +++ b/src/nouveau/compiler/nak/ir.rs @@ -5382,7 +5382,7 @@ pub struct OpSuLd { pub mem_order: MemOrder, pub mem_eviction_priority: MemEvictionPriority, - #[src_type(GPR)] + #[src_type(SSA)] pub handle: Src, #[src_type(SSA)] @@ -5413,7 +5413,7 @@ pub struct OpSuSt { pub mem_order: MemOrder, pub mem_eviction_priority: MemEvictionPriority, - #[src_type(GPR)] + #[src_type(SSA)] pub handle: Src, #[src_type(SSA)] @@ -5454,7 +5454,7 @@ pub struct OpSuAtom { pub mem_order: MemOrder, pub mem_eviction_priority: MemEvictionPriority, - #[src_type(GPR)] + #[src_type(SSA)] pub handle: Src, #[src_type(SSA)]