From 196882a1477a69ba1593db8bdaaf6726fe914fca Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Thu, 26 Jan 2023 19:08:14 +0100 Subject: [PATCH] etnaviv: drm: fix check if BO is on a deferred destroy list list_is_linked() isn't the right function to use in order to check if the BO is on a cache bucket or the zombie list, as this checks if the next pointer of the list isn't NULL. This is always the case with the BO list item as it's always initialized, so the next pointer points to the list head itself when the BO isn't on any list. Use list_is_empty() to check if the BO is actually linked into one of the deferred destroy lists. Fixes: 1b1f8592c03c ("etnaviv: drm: properly handle reviving BOs via a lookup") Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner Part-of: --- src/etnaviv/drm/etnaviv_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/etnaviv/drm/etnaviv_bo.c b/src/etnaviv/drm/etnaviv_bo.c index 2bf4357e63a..511f32a9853 100644 --- a/src/etnaviv/drm/etnaviv_bo.c +++ b/src/etnaviv/drm/etnaviv_bo.c @@ -138,8 +138,8 @@ static struct etna_bo *lookup_bo(void *tbl, uint32_t handle) /* found, incr refcnt and return: */ bo = etna_bo_ref(entry->data); - /* don't break the bucket if this bo was found in one */ - if (list_is_linked(&bo->list)) { + /* don't break the bucket/zombie list if this bo was found in one */ + if (!list_is_empty(&bo->list)) { VG_BO_OBTAIN(bo); etna_device_ref(bo->dev); list_delinit(&bo->list);