From 14428611410b6947b774688583cd15dc704e36c6 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Tue, 12 Jul 2022 12:30:00 +0200 Subject: [PATCH] v3dv: fix comment for point_sprite_mask filed in shader key MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_pipeline.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/broadcom/vulkan/v3dv_pipeline.c b/src/broadcom/vulkan/v3dv_pipeline.c index 03f5583081f..6248bb8efbf 100644 --- a/src/broadcom/vulkan/v3dv_pipeline.c +++ b/src/broadcom/vulkan/v3dv_pipeline.c @@ -1234,11 +1234,8 @@ pipeline_populate_v3d_fs_key(struct v3d_fs_key *key, } if (key->is_points) { - /* FIXME: The mask would need to be computed based on the shader - * inputs. On gallium it is done at st_atom_rasterizer - * (sprite_coord_enable). anv seems (need to confirm) to do that on - * genX_pipeline (PointSpriteTextureCoordinateEnable). Would be also - * better to have tests to guide filling the mask. + /* This mask represents state for GL_ARB_point_sprite which is not + * relevant to Vulkan. */ key->point_sprite_mask = 0;