From 13607d8c4829edda3f3b01a9bdda0ece6e1c4821 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Ondra=C4=8Dka?= Date: Tue, 12 Jul 2022 16:03:35 +0200 Subject: [PATCH] r300: don't merge w channel in fragment shaders MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Skip the merge if one of the instructions writes just w channel and we are compiling a fragment shader. We can pair-schedule it together later anyway and it will also give the scheduler a bit more flexibility. Shader-db stats with RV530: total instructions in shared programs: 169522 -> 169509 (<.01%) instructions in affected programs: 14170 -> 14157 (-0.09%) total temps in shared programs: 21712 -> 21722 (0.05%) temps in affected programs: 324 -> 334 (3.09%) Signed-off-by: Pavel Ondračka Reviewed-by: Filip Gawin Part-of: --- src/gallium/drivers/r300/compiler/radeon_optimize.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r300/compiler/radeon_optimize.c b/src/gallium/drivers/r300/compiler/radeon_optimize.c index 4d2efd7b86d..14d8eb6bb4e 100644 --- a/src/gallium/drivers/r300/compiler/radeon_optimize.c +++ b/src/gallium/drivers/r300/compiler/radeon_optimize.c @@ -1030,6 +1030,14 @@ static void merge_channels(struct radeon_compiler * c, struct rc_instruction * i cur->U.I.SaturateMode == inst->U.I.SaturateMode && (cur->U.I.DstReg.WriteMask & orig_dst_wmask) == 0) { + /* Skip the merge if one of the instructions writes just w channel + * and we are compiling a fragment shader. We can pair-schedule it together + * later anyway and it will also give the scheduler a bit more flexibility. + */ + if (c->has_omod && (cur->U.I.DstReg.WriteMask == RC_MASK_W || + inst->U.I.DstReg.WriteMask == RC_MASK_W)) + continue; + if (inst_combination(cur, inst, RC_OPCODE_MOV, RC_OPCODE_MOV)) { if (merge_movs(c, inst, cur)) return;