AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: Don't set CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER

Browse Source 
We already set HALF_INTEGER, which is what the compiler actually does.
If we also set PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER, we get
incorrect lowering. Only set the CAP we respect.

On Bifrost, this convention is arbitrary. We should consider moving the
Bifrost lowering into NIR to optimize this better...

Fixes Piglit glsl-arb-fragment-coord-conventions.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13070>
This commit is contained in:
Alyssa Rosenzweig
2021-09-27 17:32:57 -04:00
committed by Marge Bot
parent b88225378d
commit 12facf23b1
2 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/panfrost/pan_screen.c
+2 -2
View File
@@ -224,12 +224,12 @@ panfrost_get_param(struct pipe_screen *screen, enum pipe_cap param)
return MAX_MIP_LEVELS;
case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
/* Hardware is natively upper left */
case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
/* Hardware is upper left. Pixel center at (0.5, 0.5) */
return 0;
case PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT:
case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
case PIPE_CAP_TGSI_TEXCOORD:
return 1;
src/panfrost/ci/piglit-panfrost-g52-fails.txt
-15
View File
@@ -18,7 +18,6 @@ glx@glx-query-drawable-glx_fbconfig_id-window,Fail
glx@glx-swap-pixmap-bad,Fail
glx@glx-visuals-depth -pixmap,Crash
glx@glx-visuals-stencil -pixmap,Crash
shaders@glsl-arb-fragment-coord-conventions,Fail
shaders@glsl-bug-110796,Fail
shaders@glsl-fs-pointcoord,Fail
shaders@glsl-uniform-interstage-limits@subdivide 5,Crash
@@ -367,20 +366,6 @@ spec@arb_texture_multisample@arb_texture_multisample-dsa-texelfetch@Texture type
spec@arb_texture_multisample@arb_texture_multisample-dsa-texelfetch@Texture type: GL_RGBA8,Fail
spec@arb_texture_multisample@arb_texture_multisample-dsa-texelfetch@Texture type: GL_RGBA8I,Fail
spec@arb_texture_multisample@arb_texture_multisample-dsa-texelfetch@Texture type: GL_SRGB8_ALPHA8,Fail
spec@arb_texture_multisample@texelfetch@2-fs-sampler2dmsarray,Fail
spec@arb_texture_multisample@texelfetch@2-fs-sampler2dms,Fail
spec@arb_texture_multisample@texelfetch@2-vs-sampler2dmsarray,Fail
spec@arb_texture_multisample@texelfetch@2-vs-sampler2dms,Fail
spec@arb_texture_multisample@texelfetch@4-fs-sampler2dmsarray,Fail
spec@arb_texture_multisample@texelfetch@4-fs-sampler2dms,Fail
spec@arb_texture_multisample@texelfetch@4-vs-sampler2dmsarray,Fail
spec@arb_texture_multisample@texelfetch@4-vs-sampler2dms,Fail
spec@arb_texture_multisample@texelfetch fs sampler2dms 4 1x130-501x130,Fail
spec@arb_texture_multisample@texelfetch fs sampler2dms 4 1x71-501x71,Fail
spec@arb_texture_multisample@texelfetch fs sampler2dms 4 281x1-281x130,Fail
spec@arb_texture_multisample@texelfetch fs sampler2dms 4 71x1-71x130,Fail
spec@arb_texture_multisample@texelfetch fs sampler2dmsarray 4 1x129x9-98x129x9,Fail
spec@arb_texture_multisample@texelfetch fs sampler2dmsarray 4 98x1x9-98x129x9,Fail
spec@arb_texture_rectangle@1-1-linear-texture,Fail
spec@arb_texture_rectangle@tex-miplevel-selection gl2:texture() 2drect,Crash
spec@arb_texture_rectangle@tex-miplevel-selection gl2:texture() 2drectshadow,Crash