From 10a73564889a81329bf5b79744a8bc3a8c4bdeed Mon Sep 17 00:00:00 2001 From: David Rosca Date: Tue, 8 Oct 2024 10:49:50 +0200 Subject: [PATCH] radeonsi/vcn: Fix out of bounds write when invalidating QP map regions Fixes coverity issue 1559460 Out-of-bounds write Fixes: 9c07a2e10d6 ("radeonsi/vcn: ROI feature implementation") Reviewed-by: Leo Liu Part-of: --- src/gallium/drivers/radeonsi/radeon_vcn_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeon_vcn_enc.c b/src/gallium/drivers/radeonsi/radeon_vcn_enc.c index 04d39041e45..64c266a25b4 100644 --- a/src/gallium/drivers/radeonsi/radeon_vcn_enc.c +++ b/src/gallium/drivers/radeonsi/radeon_vcn_enc.c @@ -177,7 +177,7 @@ static void radeon_vcn_enc_get_roi_param(struct radeon_encoder *enc, qp_map->width_in_block = width_in_block; qp_map->height_in_block = height_in_block; - for (i = RENCODE_QP_MAP_MAX_REGIONS; i >= roi->num; i--) + for (i = RENCODE_QP_MAP_MAX_REGIONS - 1; i >= roi->num; i--) enc->enc_pic.enc_qp_map.map[i].is_valid = false; /* reverse the map sequence */