From 0f6a8283ca0eac0cf1afeeee69c08945f4917695 Mon Sep 17 00:00:00 2001 From: Mel Henning Date: Tue, 8 Jul 2025 13:44:28 -0400 Subject: [PATCH] zink: Assert ici.tiling != DRM_FORMAT_MODIFIER_EXT if we're not populating VkExternalMemoryImageCreateInfo Reviewed-by: Mike Blumenkrantz Reviewed-by: Faith Ekstrand Part-of: --- src/gallium/drivers/zink/zink_resource.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/zink/zink_resource.c b/src/gallium/drivers/zink/zink_resource.c index abdb7a34a41..c4f9ddefb56 100644 --- a/src/gallium/drivers/zink/zink_resource.c +++ b/src/gallium/drivers/zink/zink_resource.c @@ -1381,6 +1381,11 @@ create_image(struct zink_screen *screen, struct zink_resource_object *obj, emici.pNext = ici.pNext; emici.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT; ici.pNext = &emici; + } else { + /* If the frontend passed modifiers it should have also passed + * PIPE_BIND_SHARED + */ + assert(ici.tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT); } if (linear)