From 0d1813837bab65805f15172f9e6036c01b96cfab Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Tue, 18 Jun 2024 18:24:15 +0200 Subject: [PATCH] mesa: do not pass NULL pointer to function not expecting NULLs First argument for qsort() is declared to be never NULL, so ensure NULL is never passed. This has been detected by Undefined Behaviour Sanitizer (UBSan). Reviewed-by: Alyssa Rosenzweig Signed-off-by: Juan A. Suarez Romero Part-of: --- src/mesa/program/program.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index 807adbc6c82..22d5fd93e31 100644 --- a/src/mesa/program/program.c +++ b/src/mesa/program/program.c @@ -414,6 +414,9 @@ _mesa_add_separate_state_parameters(struct gl_program *prog, { unsigned num_state_params = state_params->NumParameters; + if (num_state_params == 0) + return; + /* All state parameters should be vec4s. */ for (unsigned i = 0; i < num_state_params; i++) { assert(state_params->Parameters[i].Type == PROGRAM_STATE_VAR);