From 0d13dfcf7c188f2f83e1e3a0405f867e3ed3054c Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Sun, 10 Jul 2022 16:37:25 +0200 Subject: [PATCH] etnaviv: tex_desc: remove descriptor patch TODO comment There is nothing more TODO here. With softpin, which is available on all GPUs using texture descriptors, there is no need for the kernel to patch the descriptor, as the proper GPU virtual address is filled in by userspace. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Reviewed-by: Christian Gmeiner Part-of: --- src/gallium/drivers/etnaviv/etnaviv_texture_desc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c b/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c index beb932ccde9..8e2a7632afb 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c +++ b/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c @@ -230,14 +230,12 @@ etna_sampler_view_update_descriptor(struct etna_context *ctx, struct etna_cmd_stream *stream, struct etna_sampler_view_desc *sv) { - /* TODO: this should instruct the kernel to update the descriptor when the - * bo is submitted. For now, just prevent the bo from being freed - * while it is in use indirectly. - */ struct etna_resource *res = etna_resource(sv->base.texture); + if (res->texture) { res = etna_resource(res->texture); } + /* No need to ref LOD levels individually as they'll always come from the same bo */ etna_cmd_stream_ref_bo(stream, res->bo, ETNA_RELOC_READ); }