python: Simplify list sorting
Instead of copying the list, then sorting the copy in-place, we can just get a new sorted copy directly. Signed-off-by: Mathieu Bridon <bochecha@daitauha.fr> Reviewed-by: Eric Engestrom <eric.engestrom@intel.com> Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
This commit is contained in:
committed by
Dylan Baker
parent
8d3ff6244c
commit
08fe9b3e3a
@@ -291,8 +291,7 @@ class ABIPrinter(object):
|
||||
self.entries = entries
|
||||
|
||||
# sort entries by their names
|
||||
self.entries_sorted_by_names = self.entries[:]
|
||||
self.entries_sorted_by_names.sort(key=attrgetter('name'))
|
||||
self.entries_sorted_by_names = sorted(self.entries, key=attrgetter('name'))
|
||||
|
||||
self.indent = ' ' * 3
|
||||
self.noop_warn = 'noop_warn'
|
||||
@@ -441,8 +440,7 @@ class ABIPrinter(object):
|
||||
def c_stub_string_pool(self):
|
||||
"""Return the string pool for use by stubs."""
|
||||
# sort entries by their names
|
||||
sorted_entries = self.entries[:]
|
||||
sorted_entries.sort(key=attrgetter('name'))
|
||||
sorted_entries = sorted(self.entries, key=attrgetter('name'))
|
||||
|
||||
pool = []
|
||||
offsets = {}
|
||||
|
||||
Reference in New Issue
Block a user