diff --git a/src/gallium/frontends/rusticl/api/program.rs b/src/gallium/frontends/rusticl/api/program.rs index 55e7723340e..469962c400f 100644 --- a/src/gallium/frontends/rusticl/api/program.rs +++ b/src/gallium/frontends/rusticl/api/program.rs @@ -329,13 +329,11 @@ fn build_program( } let options = c_string_to_string(options); - let res = program.build(devices, options, callback); + program.build(devices, options, callback) //• CL_INVALID_BINARY if program is created with clCreateProgramWithBinary and devices listed in device_list do not have a valid program binary loaded. //• CL_INVALID_BUILD_OPTIONS if the build options specified by options are invalid. //• CL_INVALID_OPERATION if program was not created with clCreateProgramWithSource, clCreateProgramWithIL or clCreateProgramWithBinary. - - res } #[cl_entrypoint(clCompileProgram)] @@ -413,11 +411,9 @@ fn compile_program( } let options = c_string_to_string(options); - let res = program.compile(devices, options, headers, callback); + program.compile(devices, options, headers, callback) // • CL_INVALID_COMPILER_OPTIONS if the compiler options specified by options are invalid. - - res } pub fn link_program( diff --git a/src/gallium/frontends/rusticl/core/program.rs b/src/gallium/frontends/rusticl/core/program.rs index 1feb06384ea..eb58349f5ef 100644 --- a/src/gallium/frontends/rusticl/core/program.rs +++ b/src/gallium/frontends/rusticl/core/program.rs @@ -135,7 +135,7 @@ impl ProgramBuild { } let build_result = - convert_spirv_to_nir(&build, kernel_name, &args, &self.spec_constants, dev); + convert_spirv_to_nir(build, kernel_name, &args, &self.spec_constants, dev); kernel_info_set.insert(build_result.kernel_info); self.builds_by_device.get_mut(dev).unwrap().kernels.insert( @@ -639,7 +639,7 @@ impl Program { spirv::CLCHeader { name: &header.name, - source: &header_src, + source: header_src, } }) .collect(); @@ -824,7 +824,7 @@ impl Program { is_lib: bool, device_for_validation: Option<&Device>, ) { - let (spirv, log) = spirv::SPIRVBin::link(&bins, is_lib); + let (spirv, log) = spirv::SPIRVBin::link(bins, is_lib); let (spirv, log) = if let Some(device) = device_for_validation { if let Some(spirv) = spirv { let val_options = clc_validator_options(device); @@ -1040,10 +1040,10 @@ fn create_link_closure( .map(|l| l.dev_build(device).spirv.as_ref().unwrap()) .collect(); - let mut device_build = build_info.dev_build_mut(device); + let device_build = build_info.dev_build_mut(device); let device_for_validation = Platform::dbg().validate_spirv.then_some(device); - Program::do_link(&mut device_build, &bins, is_lib, device_for_validation); + Program::do_link(device_build, &bins, is_lib, device_for_validation); } // Pre build nir kernels