From 0273f661e69e61bf9b31af8507090b645a032ddd Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Thu, 21 Apr 2022 11:08:48 +0200 Subject: [PATCH] v3dv: don't emit final noop job if we don't have anything to signal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_queue.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/broadcom/vulkan/v3dv_queue.c b/src/broadcom/vulkan/v3dv_queue.c index 32cd6eb43f7..d14d1b04c21 100644 --- a/src/broadcom/vulkan/v3dv_queue.c +++ b/src/broadcom/vulkan/v3dv_queue.c @@ -913,14 +913,16 @@ v3dv_queue_driver_submit(struct vk_queue *vk_queue, * This will ensure that the signal semaphores don't get triggered until * all work on any queue completes. */ - if (!queue->noop_job) { - result = queue_create_noop_job(queue); + if (submit->signal_count > 0) { + if (!queue->noop_job) { + result = queue_create_noop_job(queue); + if (result != VK_SUCCESS) + return result; + } + result = queue_handle_job(queue, queue->noop_job, &sync_info, true); if (result != VK_SUCCESS) return result; } - result = queue_handle_job(queue, queue->noop_job, &sync_info, true); - if (result != VK_SUCCESS) - return result; process_signals(queue, sync_info.signal_count, sync_info.signals);