From 01c59030e82d27cf14606c372a79985dff19542d Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 30 May 2025 08:38:27 -0400 Subject: [PATCH] hk: clarify A8_UNORM issue Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/vulkan/hk_image.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/asahi/vulkan/hk_image.c b/src/asahi/vulkan/hk_image.c index c9e309b8962..aaff9f8e279 100644 --- a/src/asahi/vulkan/hk_image.c +++ b/src/asahi/vulkan/hk_image.c @@ -40,15 +40,11 @@ hk_get_image_plane_format_features(struct hk_physical_device *pdev, { VkFormatFeatureFlags2 features = 0; - /* Conformance fails with these optional formats. Just drop them for now. - * TODO: Investigate later if we have a use case. + /* A8 with opaque black needs custom borders, so hide for performance. We + * might specially enable this for Proton / behind a driconf. */ - switch (vk_format) { - case VK_FORMAT_A8_UNORM_KHR: + if (vk_format == VK_FORMAT_A8_UNORM_KHR) return 0; - default: - break; - } enum pipe_format p_format = hk_format_to_pipe_format(vk_format); if (p_format == PIPE_FORMAT_NONE)