From 00fb0f5ec20ae8fdbec2fcf2c3f9becdb59d9207 Mon Sep 17 00:00:00 2001 From: Benjamin Lee Date: Thu, 23 Jan 2025 08:16:10 -0800 Subject: [PATCH] panvk: enable KHR_separate_depth_stencil_layouts Panvk doesn't use image layouts for anything, so we don't need any changes to support this. New fails in g52 CI expectations are *_separate_layouts variants of existing failing tests, that were previously skipped. Signed-off-by: Benjamin Lee Reviewed-by: Erik Faye-Lund Part-of: --- docs/features.txt | 2 +- src/panfrost/vulkan/panvk_physical_device.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 7d21cbf9953..428bb19603f 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -466,7 +466,7 @@ Vulkan 1.2 -- all DONE: anv, nvk, tu, vn VK_KHR_image_format_list DONE (anv, dzn, hasvk, lvp, nvk, panvk, pvr, radv, tu, v3dv, vn) VK_KHR_imageless_framebuffer DONE (anv, dzn, hasvk, lvp, nvk, radv, tu, v3dv, vn) VK_KHR_sampler_mirror_clamp_to_edge DONE (anv, dzn, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn) - VK_KHR_separate_depth_stencil_layouts DONE (anv, dzn, hasvk, lvp, nvk, radv, tu, v3dv, vn) + VK_KHR_separate_depth_stencil_layouts DONE (anv, dzn, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn) VK_KHR_shader_atomic_int64 DONE (anv, lvp, nvk, radv, vn, tu/a740+) VK_KHR_shader_float16_int8 DONE (anv, dzn, nvk, hasvk, lvp, radv, tu, vn, panvk) VK_KHR_shader_float_controls DONE (anv, dzn, hasvk, lvp, nvk, radv, tu, v3dv, vn) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index f63dabddc31..17d1b925e82 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -209,6 +209,7 @@ get_device_extensions(const struct panvk_physical_device *device, .KHR_push_descriptor = true, .KHR_relaxed_block_layout = true, .KHR_sampler_mirror_clamp_to_edge = true, + .KHR_separate_depth_stencil_layouts = true, .KHR_shader_draw_parameters = true, .KHR_shader_expect_assume = true, .KHR_shader_float16_int8 = true, @@ -337,7 +338,7 @@ get_features(const struct panvk_physical_device *device, .imagelessFramebuffer = false, .uniformBufferStandardLayout = false, .shaderSubgroupExtendedTypes = false, - .separateDepthStencilLayouts = false, + .separateDepthStencilLayouts = true, .hostQueryReset = true, .timelineSemaphore = true, .bufferDeviceAddress = true,