From 008f5a127cdee30f774a000ad493369a7dcd366a Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 13 Nov 2021 11:50:07 -0800 Subject: [PATCH] ac/rgp: Initialize clock_calibration with memset. Fix defect reported by Coverity Scan. Uninitialized scalar variable (UNINIT) uninit_use_in_call: Using uninitialized value clock_calibration. Field clock_calibration.reserved is uninitialized when calling fwrite. Fixes: 1ee85e8babe ("ac/rgp: add support for clock calibration") Suggested-by: Bas Nieuwenhuizen Signed-off-by: Vinson Lee Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/common/ac_rgp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_rgp.c b/src/amd/common/ac_rgp.c index 24ea488cd5b..3cd81b40e6a 100644 --- a/src/amd/common/ac_rgp.c +++ b/src/amd/common/ac_rgp.c @@ -1145,6 +1145,7 @@ static void ac_sqtt_dump_data(struct radeon_info *rad_info, list_for_each_entry_safe(struct rgp_clock_calibration_record, record, &rgp_clock_calibration->record, list) { struct sqtt_file_chunk_clock_calibration clock_calibration; + memset(&clock_calibration, 0, sizeof(clock_calibration)); ac_sqtt_fill_clock_calibration(&clock_calibration, num_records);